mirror of
https://github.com/CyberMind-FR/secubox-deb.git
synced 2026-07-29 09:14:33 +00:00
fix(scripts): use issue title for PR, surface push errors as exit 4 (ref #83)
Addresses code review: - Important #4: finish now fetches issue title via `gh issue view --json title` and uses it as PR title (was using the branch name). Falls back to branch name if the fetch fails or returns empty. - Minor #8: explicit `return 4` on `git push` failure for consistency with the documented exit-code contract. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
676b842f23
commit
c661c4f053
|
|
@ -200,14 +200,23 @@ cmd_finish() {
|
|||
echo "finish: cannot parse issue number from branch '$branch'" >&2; return 1
|
||||
fi
|
||||
|
||||
local issue_title
|
||||
issue_title=$("$GH_BIN" issue view "$issue" --json title 2>/dev/null \
|
||||
| sed -E 's/.*"title":"((\\.|[^"\\])*)".*/\1/')
|
||||
if [[ -z "$issue_title" || "$issue_title" == *'"title"'* ]]; then
|
||||
issue_title="$branch"
|
||||
fi
|
||||
|
||||
if (( dry_run )); then
|
||||
echo "dry-run: would push $branch and open PR closing #$issue"
|
||||
echo "dry-run: would push $branch and open PR closing #$issue with title '$issue_title'"
|
||||
return 0
|
||||
fi
|
||||
|
||||
"$GIT_BIN" push -u origin "$branch" >/dev/null
|
||||
if ! "$GIT_BIN" push -u origin "$branch" >/dev/null; then
|
||||
echo "finish: git push failed" >&2; return 4
|
||||
fi
|
||||
"$GH_BIN" pr create --base master --head "$branch" \
|
||||
--title "$branch" --body "Closes #$issue" \
|
||||
--title "$issue_title" --body "Closes #$issue" \
|
||||
|| return 4
|
||||
}
|
||||
cmd_clean() {
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user